-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ember@4 support #1256
feat: ember@4 support #1256
Conversation
…-select@^7.2.0`.
…-css-transitions#dist`.
ooo nice one! 🎉 it looks like we're both thinking the same thing at the moment 😂 |
oop, looks like I need to merge in upstream.. |
Do you have contrib access to
|
I don't have access to ember-css-transitions no, but it looks like it's active enough so I wouldn't worry about opening up a PR there. Why are you asking about utils though? It looks like the deployed version of the package is inlining the utils imports in the dist: https://unpkg.com/browse/ember-css-transitions@4.4.0/dist/modifiers/css-transition.js#L44 |
omg... you're kidding... I couldn't see a mention to this change in the changelog, and theres an issue from last year that didn't clarify or point to where the utils had moved to: miguelcobain/ember-css-transitions#120 Righto, all of these will be an easy change then!! one momento..
|
Cool, so the tests look like they are failing due to scope (probably non-explicit this e.t.c). I'll look at patching that tomorrow. :)
|
So if we get a small pr of yours merged then you won't need me to approve the tests any more. Maybe extract the ember-css-transition upgrade on its own |
@mansona it builds...
Haven't got to the point of running codemods/testing it yet as I just needed our apps to compile on ember@5 before circling back to upgrading/fixing
ember-paper